On 2016-04-22 20:39:27 +1200, Thomas Munro wrote: > I vote to leave this patch in the next commitfest where it is, and > reconsider if someone shows up with a relevant problem report on large > systems.
Sounds good! > Here's a new version of the patch that fixes some stupid bugs. I have > run regression tests and some basic sanity checks on OSX 10.11.4, > FreeBSD 10.3, NetBSD 7.0 and OpenBSD 5.8. There is still room to make > an improvement that would drop the syscall from AddWaitEventToSet and > ModifyWaitEvent, compressing wait set modifications and waiting into a > single syscall (kqueue's claimed advantage over the competition). I find that not to be particularly interesting, and would rather want to avoid adding complexity for it. > While doing that I discovered that unpatched master doesn't actually > build on recent NetBSD systems because our static function strtoi > clashes with a non-standard libc function of the same name declared > in inttypes.h. Maybe we should rename it, like in the attached? Yuck. That's a new function they introduced? That code hasn't changed in a while.... Andres -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers