On Tue, Jun 28, 2016 at 11:43 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp > wrote:
> On 2016/06/28 13:53, Ashutosh Bapat wrote: > >> Ideally, we should point out the specific column that faced the >> conversion problem and report it, instead of saying the whole row >> reference conversion caused the problem. But that may be too difficult. >> > > I think so too. > > Or at least the error message should read "whole row reference of >> foreign table ft1". >> > > OK, attached is an updated version of the patch, which uses "whole-row > reference", not "wholerow". > The wording "column "whole-row reference ..." doesn't look good. Whole-row reference is not a column. The error context itself should be "whole row reference for foreign table ft1". -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company