On Fri, Sep 30, 2016 at 8:58 PM, Jeevan Chalke <jeevan.cha...@enterprisedb.com> wrote: > On Mon, Sep 26, 2016 at 6:15 PM, Ashutosh Bapat > <ashutosh.ba...@enterprisedb.com> wrote: >> >> This patch will need some changes to conversion_error_callback(). That >> function reports an error in case there was an error converting the >> result obtained from the foreign server into an internal datum e.g. >> when the string returned by the foreign server is not acceptable by >> local input function for the expected datatype. In such cases, the >> input function will throw error and conversion_error_callback() will >> provide appropriate context for that error. postgres_fdw.sql has tests >> to test proper context >> We need to fix the error context to provide meaningful information or >> at least not crash. This has been discussed briefly in [1]. > > Oops. I had that in mind when working on this. Somehow skipped checking > for conversion error context. I have fixed that in v3 patch. > Removed assert and for non Var expressions, printing generic context. > This context is almost in-line with the discussion you referred here.
Moved to next CF. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
