On Thu, Oct 13, 2016 at 9:23 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 10/12/16 7:38 PM, Andres Freund wrote: >>> We generally don't build test code during make world. >> FWIW, I find that quite annoying. I want to run make world with parallelism >> so >> I can run make world afterwards with as little unnecessary >> unparallelized work. And since the latter takes just about forever, any >> errors visible earlier are good. >> >> What are we gaining by this behaviour? > > Well, the purpose of make all or make world is to build the things that > are to be installed by make install or make install-world, which is the > stuff that users want to use. The purpose is not necessarily to build > stuff for the amusement of developers. Remember that we used to have > some dusty corners under src/test/, so "build everything no matter what" > is/was not a clearly better strategy. Also, some test code used to take > a relatively long time to build, which led to some level of annoyance. > > It might be worth reviewing this approach, but that's what it is.
Well, I think what Tom, Andres, Michael, and I are saying is precisely that we should review this approach and revise it so that 'make world' builds everything. Or else add 'make universe' to really build everything, but personally I think that's an unnecessary complication. The difference between 'make world' and a full build is probably not enough that many people are going to care much about the difference in compilation time. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers