On 10/25/16 1:38 AM, Haribabu Kommi wrote: > Here I attached the first version of patch that supports both EUI-48 and > EUI-64 type > Mac addresses with a single datatype called macaddr. This is an variable > length > datatype similar like inet. It can store both 6 and 8 byte addresses. > Variable length > type is used because in case in future, if MAC address gets enhanced, > still this type > can support without breaking DISK compatibility.
Since the world knows the 6-byte variant as MAC-48, shouldn't it be renamed to macaddr48 or even mac48? > Currently the patch lacks of documentation. Comments? For patches like this, it would be good if you included a mock commit message so that someone who comes in late knows what's going on. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers