On Fri, Oct 28, 2016 at 3:40 AM, Andres Freund <and...@anarazel.de> wrote: >> >> There is not much common functionality between the two. > > I don't really agree. For me manual and automated prewarming are pretty > closely related. Sure they have their independent usages, and not too > much code might be shared. But grouping them in the same extension seems > to make sense, it's confusing to have closely related but independent > extensions.
I agree that putting them together would be fine. >> One point that seems to be worth discussing is when should the buffer >> information be dumped to a file? Shall we dump at each checkpoint or >> at regular intervals via auto prewarm worker or at some other time? > > Should probably be at some regular interval - not sure if checkpoints > are the best time (or if it's even realistic to tie a bgworker to > checkpoints), since checkpoints have a significant impact on the state > of shared_buffers. Checkpoints don't cause any buffer replacement, which I think is what would be relevant here. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
