On 18 November 2016 at 05:41, Robert Haas <robertmh...@gmail.com> wrote:
> On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer <cr...@2ndquadrant.com> wrote:
>> On 17 November 2016 at 10:42, Craig Ringer <cr...@2ndquadrant.com> wrote:
>>> But sure, if it's easier, we can have 5.8.0 in the README. What's five
>>> extra years matter anyway? Hey, while we're at it, lets change Pg to
>>> build on Borland C and require K&R style!
>> Sorry. That was unnecessary. I should've had the sense to save that as
>> a draft and come back later.
> Well, *I* thought it was pretty funny...
> I remember K&R style rather fondly.  Of course it was inferior
> technically, but if you could get things to compile that way you could
> feel like a wizard for being able to make the old compiler work.

Rather. I remember getting modern software to compile on SCO
OpenServer 5.0.5 that way. *Twich* *twitch*.

Anyway, here's an updated patch with version changed to 5.8.4 since
that's the newest we test on the buildfarm (and it's from 2004).

I wasted a bunch of time getting set up to test for such an ancient
Perl and would love to save the next person along the hassle by
documenting the easy way.

 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From 2a911dda796e88c88703095ad2f34cb73ccf919b Mon Sep 17 00:00:00 2001
From: Craig Ringer <cr...@2ndquadrant.com>
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.4 is required for TAP tests

We don't test with anything older than Perl 5.8.4 in the buildfarm
and it's from 2004, so document that the TAP tests are expected to
work with Perl 5.8.4 and explain how to get it easily.

This does not affect configure tests; we'll still compile against
an older Perl 5.8.x if there's one in the wild.
 src/test/perl/README | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..9c8bd05 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
     perldoc src/test/perl/PostgresNode.pm
+Required Perl
+Tests must run on perl 5.8.4 and newer. perlbrew is a good way to obtain
+such a Perl; see https://metacpan.org/pod/distribution/App-perlbrew/bin/perlbrew .
+Just install and
+    perlbrew --force install 5.8.4
+    perlbrew use 5.8.4
+    perlbrew install-cpanm
+    cpanm install IPC::Run
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+    grep ^PERL= config.log

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to