Here's a summary for what I tested  in RHEL7.0, details follow.

1. apply patch and make world 
  -> failed because </para> was mistakenly coded <para>.

2.correct this mistake and make check-world
  -> got 1 failed test: "'pg_dumpall with \n\r in database name'"
     because test script cannot createdb "foo\n\rbar" 

Details follows:
[1. apply patch and make world>]

I tried to make world after applying patch and there seems to be one small 
mistake in create_role. 

openjade:ref/create_role.sgml:413:7:E: document type does not allow element 
"PARA" here; missing one of "FOOTNOTE", "ITEMIZEDLIST", "ORDEREDLIST", 
openjade:ref/create_role.sgml:414:11:E: end tag for "PARA" omitted, but OMITTAG 
NO was specified
openjade:ref/create_role.sgml:413:2: start tag was here
openjade:ref/create_role.sgml:414:11:E: end tag for "PARA" omitted, but OMITTAG 
NO was specified
openjade:ref/create_role.sgml:408:2: start tag was here
make[3]: *** [HTML.index] Error 1
make[3]: *** Deleting file `HTML.index'


[2.correct this mistake and make check-world]
After fixing this mistake locally by correcting <para> to end tag, postgresql 
and documentation were successfully made.
And also "make check" tests passed (not "make check-world").

diff --git a/doc/src/sgml/ref/create_role.sgml 
index 9d6926e..ff4b6f6 100644
--- a/doc/src/sgml/ref/create_role.sgml
+++ b/doc/src/sgml/ref/create_role.sgml
@@ -410,7 +410,7 @@ CREATE ROLE <replaceable 
class="PARAMETER">name</replaceable> [ [ WITH ] <replac
    as those could be at the origin of security breaches, particularly on
    Windows where the command shell is unusable with arguments containing
    such characters.
-  <para>
+  </para>

This failure seems actually caused by t/010_dump_connstr.pl line 65
"$node->run_log(['createdb', "foo\n\rbar"]);".

This means your patch works well.

Excerpt from log follows. 
#   Failed test 'pg_dumpall with \n\r in database name'
#   at 
line 230.
# Looks like you failed 1 test of 14.
t/010_dump_connstr.pl .. 

not ok 6 - pg_dumpall with \n\r in database name

Failed 1/14 subtests 

Test Summary Report
t/010_dump_connstr.pl (Wstat: 256 Tests: 14 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
Files=3, Tests=1822, 58 wallclock secs ( 0.20 usr  0.01 sys + 12.52 cusr  1.94 
csys = 14.67 CPU)
Result: FAIL

Ideriha, Takeshi

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to