On Thu, Nov 17, 2016 at 10:56 PM, Dmitry Dolgov <9erthali...@gmail.com> wrote:
> > On 15 November 2016 at 15:03, Aleksander Alekseev < > a.aleks...@postgrespro.ru> wrote: > > Hello. > > > > I took a look on the latest -v4 patch. I would like to note that this > > patch breaks a backward compatibility. For instance sr_plan extension[1] > > stop to compile with errors > > Thank you for the feedback. > > Well, if we're speaking about this particular extension, if I understood > correctly, it fetches all parse tree nodes from Postgres and generates code > using this information. So to avoid compilation problems I believe you > need to > run `make USE_PGXS=1 genparser` again (it worked for me, I don't see any > mentions of `ArrayRef`). > > But speaking generally, I don't see how we can provide backward > compatibility > for those extensions, who are strongly coupled with implementation details > of > parsing tree. I mean, in terms of interface it's mostly about to replace > `ArrayRef` to `SubscriptingRef`, but I think it's better to do it in the > extension code. > Moved to next CF with "needs review" status. Regards, Hari Babu Fujitsu Australia
