On Tue, Feb 7, 2017 at 6:32 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Jan 31, 2017 at 9:36 PM, Robert Haas <robertmh...@gmail.com> wrote: >> >> + if (!HeapTupleHeaderXminFrozen(page_htup)) >> + page_htup->t_infomask |= HEAP_XACT_MASK; >> + else >> + page_htup->t_infomask |= HEAP_XMAX_COMMITTED | >> HEAP_XMAX_INVALID; >> >> Comment doesn't address this logic. Also, the "else" case shouldn't >> exist at all, I think. >> > > In the *if* check, it just checks frozen status of xmin, so I think > you need to mask xmax related bits in else check. Can you explain > what makes you think that the else case shouldn't exist?
Oh, you're right. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers