On Thu, Feb 9, 2017 at 1:11 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> I think you should just tighten up the sanity checking in the existing >> function _hash_ovflblkno_to_bitno rather than duplicating the code. I >> don't think it's called often enough for one extra (cheap) test to be >> an issue. (You should change the elog in that function to an ereport, >> too, since it's going to be a user-facing error message now.) > > okay, I have taken care of above two points in the attached patch. Thanks.
Alright, committed with a little further hacking. That would rejected using hash_bitmap_info() on primary bucket pages and the metapage, but not on bitmap pages, which seems weird. So I fixed that and pushed this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers