That is accurate. The only positive it has is that the user only
experiences one error, and it's the first error that was encountered if
reading top-to-bottom, left to right. It is an issue of which we prioritize
- user experience or simpler code.
Hmmm. The last simpler structure I suggested, which is basically the one
used in your code before the update, does check for the structure error
first. The only drawback is that the condition is only evaluated when
needed, which is an issue we can cope with, IMO.
Now if you want to require committer opinion on this one, fine with me.
Rather than speculate on what a committer thinks of this edge case (and
making a patch for each possible theory), I'd rather just ask them what
their priorities are and which user experience they favor.
ISTM that the consistent message by Robert & Tom was to provide simpler
code even if the user experience is somehow degraded, as they required
that user-friendly features were removed (eg trying to be nicer about
structural syntax errors, barking in interactive mode so that the user
always knows the current status, providing a detailed status indicator in
Now committers can change their opinions, it is their privilege:-)
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: