On Sat, Mar 4, 2017 at 1:46 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 3/3/17 13:58, Petr Jelinek wrote: >> On 23/02/17 08:24, Masahiko Sawada wrote: >>> Attached updated version patches. Please review these. >>> >> >> This version looks good to me, I'd only change the >> >>> + PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION >>> CREATE SLOT"); >> >> to "CREATE SUBSCRIPTION ... CREATE SLOT" as that's afaik how we do it >> for other commands (and same with DROP). > > I have committed fixes for these issues.
Thanks! > > I didn't like the syntax change in DROP SUBSCRIPTION, so I have just > fixed the parsing of the existing syntax. We can discuss syntax changes > separately. Understood. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers