On Fri, Mar 17, 2017 at 2:08 AM, Beena Emerson <memissemer...@gmail.com> wrote: > The option was intended to only accept values in MB as the original config > --with-wal-segsize option, unfortunately, the patch does not throw error as > in the config option when the units are specified.
Yeah, you want to use strtol(), so that you can throw an error if *endptr isn't '\0'. > Error with config option --with-wal-segsize=1MB > configure: error: Invalid WAL segment size. Allowed values are > 1,2,4,8,16,32,64. > > Should we imitate this behaviour and just add a check to see if it only > contains numbers? or would it be better to allow the use of the units and > make appropriate code changes? I think just restricting it to numeric values would be fine. If somebody wants to do the work to make it accept a unit suffix, I don't have a problem with that, but it doesn't seem like a must-have. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers