On 3/16/17 12:48 PM, David Steele wrote:
This patch looks pretty straight forward and applies cleanly and
compiles at cccbdde.
It's not a straight revert, though, so still seems to need review.
Jim, do you know when you'll have a chance to look at that?
Yes. Compiles and passes for me as well.
One minor point: previously the code did
if (buf->usage_count < BM_MAX_USAGE_COUNT)
but now it does
if (BUF_STATE_GET_USAGECOUNT(buf_state) != BM_MAX_USAGE_COUNT)
being prone to paranoia, I prefer the first, but I've seen both styles
in the code so I don't know if it's worth futzing with.
Marked as RFC.
--
Jim Nasby, Chief Data Architect, Austin TX
OpenSCG http://OpenSCG.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
