On 29 March 2017 at 16:19, Dmitry Dolgov <9erthali...@gmail.com> wrote: >> On 29 March 2017 at 18:28, Andrew Dunstan <andrew.duns...@2ndquadrant.com> >> wrote: >> >> These patches seem fundamentally OK. But I'm still not happy with the >> naming etc. > > I've changed names for all functions and action definitions, moved out the > changes in header file to `jsonapi.h` and removed `is_jsonb_data` macro. So > it > should be better now.
I have just noticed as I was writing/testing the non-existent docs for this patch that it doesn't supply variants of to_tsvector that take a regconfig as the first argument. Is there a reason for that? Why should the json(b) versions be different from the text versions? cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers