On Thu, Apr 06, 2017 at 01:38:41PM -0400, Peter Eisentraut wrote: > On 3/24/17 10:49, Petr Jelinek wrote: > >>>>> On 07/03/17 06:23, Petr Jelinek wrote: > >>>>>> there has been discussion at the logical replication initial copy > >>>>>> thread > >>>>>> [1] about making apply work with sync commit off by default for > >>>>>> performance reasons and adding option to change that per subscription. > >>>>>> > >>>>>> Here I propose patch to implement this - it adds boolean column > >>>>>> subssynccommit to pg_subscription catalog which decides if > >>>>>> synchronous_commit should be off or local for apply. And it adds > >>>>>> SYNCHRONOUS_COMMIT = boolean to the list of WITH options for CREATE and > >>>>>> ALTER SUBSCRIPTION. When nothing is specified it will set it to false. > > > Rebase after table copy patch got committed. > > I think this change could use some more documentation. Under what > circumstances would a user want to turn this back on?
[Action required within three days. This is a generic notification.] The above-described topic is currently a PostgreSQL 10 open item. Peter, since you committed the patch believed to have created it, you own this open item. If some other commit is more relevant or if this does not belong as a v10 open item, please let us know. Otherwise, please observe the policy on open item ownership[1] and send a status update within three calendar days of this message. Include a date for your subsequent status update. Testers may discover new open items at any time, and I want to plan to get them all fixed well in advance of shipping v10. Consequently, I will appreciate your efforts toward speedy resolution. Thanks. [1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
