On 4/16/17 16:11, Petr Jelinek wrote: > Yeah it is, it needs to be fenced to happen only after commit, which is > not guaranteed at the point of code, we probably need to put the > pgstat_report_stat() inside the if above after the > CommitTransactionCommand() (that will make it report stats for changes > apply did to pg_subscription_rel after next transaction though)
I think to avoid the latter, we should add more pgstat_report_stat() calls, such as in process_syncing_tables_for_apply(). Basically every code path that calls CommitTransactionCommand() should have one, no? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
