On 2017-05-03 08:17, Petr Jelinek wrote:
On 02/05/17 20:43, Robert Haas wrote:
On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut

code path that calls CommitTransactionCommand() should have one, no?

Is there anything left to be committed here?


Afaics the fix was not committed. Peter wanted more comprehensive fix
which didn't happen. I think something like attached should do the job.

I'm running my pgbench-over-logical-replication test in chunk of 15 minutes, wth different pgbench -c (num clients) and -s (scale) values.

With this patch (and nothing else) on top of master (8f8b9be51fd7 to be precise):

fix-statistics-reporting-in-logical-replication-work.patch

logical replication is still often failing (as expected, I suppose; it seems because of "inital snapshot too large") but indeed I do not see the 'TRAP: FailedAssertion in pgstat.c' anymore.

(If there is any other configuration of patches worth testing please let me know)

thanks

Erik Rijkers



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to