On Sat, Apr 22, 2017 at 12:46 PM, Pierre Ducroquet <p.p...@pinaraf.info> wrote: >> Here are the general guidelines about patch submission: >> https://wiki.postgresql.org/wiki/Submitting_a_Patch >> And the best thing would be to register it to the next commit fest so >> as it does not get lost: >> https://commitfest.postgresql.org/ > > Thank you, I added an entry in the next commit fest.
Isn't (strtol_endptr != optarg + strlen(optarg))) just a really inefficient way of writing (strtol_endptr != '\0')? I would be inclined to write tests like if (standby_message_timeout < 0 || strtol_endptr != optarg + strlen(optarg)) in the other order; that is, test strtol_endptr first, and only test the other conditions if that test passes. I would probably also just use endptr rather than strtol_endptr, for brevity. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
