On Wed, May 10, 2017 at 10:22 PM, Michael Paquier <[email protected]> wrote: > On Wed, May 10, 2017 at 10:01 PM, Tom Lane <[email protected]> wrote: >> Heikki Linnakangas <[email protected]> writes: >>> Also note that changing the signature check_password_hook_type would >>> break any external modules that use the hook. Removing >>> PASSWORD_TYPE_PLAINTEXT will do that too, because any password hook >>> function would use that constant (see e.g. contrib/passwordcheck). If we >>> were to change the signature, I'd actually like to simplify it by >>> removing the password_type parameter altogether. The hook function can >>> call get_password_type() on the password itself to get the same >>> information. But it's not worth changing the API and breaking external >>> modules for that. > > Ahah. I just had the same thought before reading this message.
And attached is a patch to do that. I am all for this one to get a more simple interface in place. -- Michael
simplify-passwd-hook.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
