On Sun, May 21, 2017 at 10:12:20AM -0400, Tom Lane wrote: > Piotr Stefaniak <postg...@piotr-stefaniak.me> writes: > > On 2017-05-21 03:00, Tom Lane wrote: > >> I wrote: > >>> Also, I found two places where an overlength comment line is simply busted > >>> altogether --- notice that a character is missing at the split point: > > >> I found the cause of that: you need to apply this patch: > > > I have been analyzing this and came to different conclusions. > > Well, the code as it stands breaks those two comments (and a third one > I'd failed to notice before). With the patch I propose, the only changes > are that those comments are left unmolested. So even aside from the > fact that this code is visibly unsafe, it does correspond to the symptom.
Frankly, I found it ironic that the BSD indent code, which was designed to improve code clarity, was so confusingly written. I went with the sed script (and later Perl script) wrapper solution because the BSD indent code was so confusing to me. It seems like a "The Cobbler's children have no shoes" syndrome: https://english.stackexchange.com/questions/159004/the-cobblers-children-have-no-shoes -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers