On 05/31/17 01:26, Tom Lane wrote:
> Hm. I think it would be better to use DatumGetInt32 here. Arguably,
> direct use of GET_4_BYTES and its siblings should only appear in
> DatumGetFoo macros.
Like so? These are the 4 sites where {GET,SET}_n_BYTES got introduced
in 14cca1b (for consistency, though only the GET_4 case produces warnings).
-Chap
--- src/include/postgres.h 2017-05-31 01:36:16.621829183 -0400
+++ src/include/postgres.h 2017-05-31 01:45:51.303427115 -0400
@@ -679,7 +679,7 @@
float4 retval;
} myunion;
- myunion.value = GET_4_BYTES(X);
+ myunion.value = DatumGetInt32(X);
return myunion.retval;
}
#else
@@ -704,7 +704,7 @@
} myunion;
myunion.value = X;
- return SET_4_BYTES(myunion.retval);
+ return Int32GetDatum(myunion.retval);
}
#else
extern Datum Float4GetDatum(float4 X);
@@ -727,7 +727,7 @@
float8 retval;
} myunion;
- myunion.value = GET_8_BYTES(X);
+ myunion.value = DatumGetInt64(X);
return myunion.retval;
}
#else
@@ -753,7 +753,7 @@
} myunion;
myunion.value = X;
- return SET_8_BYTES(myunion.retval);
+ return Int64GetDatum(myunion.retval);
}
#else
extern Datum Float8GetDatum(float8 X);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
