On 6/14/17 18:35, Petr Jelinek wrote: > Attached fixes it (it was mostly about order of calls).
So do I understand this right that the actual fix is just moving up the logicalrep_worker_stop() call in DropSubscription(). > I also split the > SetSubscriptionRelState into 2 separate interface while I was changing > it, because now that the update_only bool was added it has become quite > strange to have single interface for what is basically two separate > functions. makes sense > Other related problem is locking of subscriptions during operations on > them, especially AlterSubscription seems like it should lock the > subscription itself. I did that in 0002. More detail here please. AlterSubscription() does locking via heap_open(). This introduces a new locking method. What are the implications? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
