On 2017/07/12 4:24, Dean Rasheed wrote: > On 11 July 2017 at 13:29, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> > wrote: >> Most of the patch seems to be replacing "content" with "kind", >> RangeDatumContent with PartitionRangeDatumKind and RANGE_DATUM_FINITE >> with PARTITION_RANGE_DATUM_VALUE. But those changes in name don't seem >> to be adding much value to the patch. Replacing RANGE_DATUM_NEG_INF >> and RANGE_DATUM_POS_INF with PARTITION_RANGE_DATUM_MINVALUE and >> PARTITION_RANGE_DATUM_MAXVALUE looks like a good change in line with >> MINVALUE/MAXVALUE change. May be we should reuse the previous >> variables, enum type name and except those two, so that the total >> change introduced by the patch is minimal. >> > > No, this isn't just renaming that other enum. It's about replacing the > boolean "infinite" flag on PartitionRangeDatum with something that can > properly enumerate the 3 kinds of PartitionRangeDatum that are allowed > (and, as noted above "finite"/"infinite isn't the right terminology > either). Putting that new enum in parsenodes.h makes it globally > available, wherever the PartitionRangeDatum structure is used. A > side-effect of that change is that the old RangeDatumContent enum that > was local to partition.c is no longer needed. > > RangeDatumContent wouldn't be a good name for a globally visible enum > of this kind because that name fails to link it to partitioning in any > way, and could easily be confused as having something to do with RTEs > or range types. Also, the term "content" is more traditionally used in > the Postgres sources for a field *holding* content, rather than a > field specifying the *kind* of content. On the other hand, you'll note > that the term "kind" is by far the most commonly used term for naming > this kind of enum, and any matching fields. > > IMO, code consistency and readability takes precedence over keeping > patch sizes down.
I agree with Dean here that the new global PartitionRangeDatumKind enum is an improvement over the previous infinite flag in the parse node plus the partition.c local RangeDatumContent enum for all the reasons he mentioned. Thanks, Amit -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers