On 2017/08/10 18:52, Beena Emerson wrote: > Hi Amit, > > On Thu, Aug 10, 2017 at 7:41 AM, Amit Langote > <langote_amit...@lab.ntt.co.jp> wrote: >> On 2017/08/05 2:25, Robert Haas wrote: >>> Concretely, my proposal is: >>> >>> P.S. While I haven't reviewed 0002 in detail, I think the concept of >>> minimizing what needs to be built in RelationGetPartitionDispatchInfo >>> is a very good idea. >> >> I put this patch ahead in the list and so it's now 0001. >> > > FYI, 0001 patch throws the warning: > > execMain.c: In function ‘ExecSetupPartitionTupleRouting’: > execMain.c:3342:16: warning: ‘next_ptinfo’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > next_ptinfo->parentid != ptinfo->parentid)
Thanks for the review. Will fix in the updated version of the patch I will post sometime later today. Regards, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
