On Fri, Aug 18, 2017 at 1:56 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > + /* > + * We have already checked the column list in vacuum(...), > + * but the columns may have disappeared since then. If > + * this happens, emit a nice warning message and skip the > + * undefined column. > + */ > I think that this would be reworded. "nice" is cute is this context. > Why not just saying something like: > "Do not issue an ERROR if a column is missing but use a WARNING > instead. At the beginning of the VACUUM run, the code already checked > for undefined columns and informed about an ERROR, but we want the > processing to move on for existing columns."
Hmm, I find your (Michael's) suggestion substantially less clear than the wording to which you are objecting. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
