Thanks Dilip. I am working on rebasing the patch. Particularly, the partition walker in my patch depended on the fact that all the tables get opened (and then closed) while creating the tuple routing info. But in HEAD, now only the partitioned tables get opened. So need some changes in my patch.
The partition walker related changes are going to be inapplicable once the other thread [1] commits the changes for expansion of inheritence in bound-order, but till then I would have to rebase the partition walker changes over HEAD. [1] https://www.postgresql.org/message-id/0118a1f2-84bb-19a7-b906-dec040a206f2%40lab.ntt.co.jp On 31 August 2017 at 12:09, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Fri, Aug 11, 2017 at 10:44 AM, Amit Khandekar <amitdkhan...@gmail.com> > wrote: >> On 4 August 2017 at 22:28, Amit Khandekar <amitdkhan...@gmail.com> wrote: >>>> > > I am planning to review and test this patch, Seems like this patch > needs to be rebased. > > [dilip@localhost postgresql]$ patch -p1 < > ../patches/update-partition-key_v15.patch > patching file doc/src/sgml/ddl.sgml > patching file doc/src/sgml/ref/update.sgml > patching file doc/src/sgml/trigger.sgml > patching file src/backend/catalog/partition.c > Hunk #3 succeeded at 910 (offset -1 lines). > Hunk #4 succeeded at 924 (offset -1 lines). > Hunk #5 succeeded at 934 (offset -1 lines). > Hunk #6 succeeded at 994 (offset -1 lines). > Hunk #7 succeeded at 1009 with fuzz 1 (offset 3 lines). > Hunk #8 FAILED at 1023. > Hunk #9 succeeded at 1059 with fuzz 2 (offset 10 lines). > Hunk #10 succeeded at 2069 (offset 2 lines). > Hunk #11 succeeded at 2406 (offset 2 lines). > 1 out of 11 hunks FAILED -- saving rejects to file > src/backend/catalog/partition.c.rej > patching file src/backend/commands/copy.c > Hunk #2 FAILED at 1426. > Hunk #3 FAILED at 1462. > Hunk #4 succeeded at 2616 (offset 7 lines). > Hunk #5 succeeded at 2726 (offset 8 lines). > Hunk #6 succeeded at 2846 (offset 8 lines). > 2 out of 6 hunks FAILED -- saving rejects to file > src/backend/commands/copy.c.rej > patching file src/backend/commands/trigger.c > Hunk #4 succeeded at 5261 with fuzz 2. > patching file src/backend/executor/execMain.c > Hunk #1 succeeded at 65 (offset 1 line). > Hunk #2 succeeded at 103 (offset 1 line). > Hunk #3 succeeded at 1829 (offset 20 lines). > Hunk #4 succeeded at 1860 (offset 20 lines). > Hunk #5 succeeded at 1927 (offset 20 lines). > Hunk #6 succeeded at 2044 (offset 21 lines). > Hunk #7 FAILED at 3210. > Hunk #8 FAILED at 3244. > Hunk #9 succeeded at 3289 (offset 26 lines). > Hunk #10 FAILED at 3340. > Hunk #11 succeeded at 3387 (offset 29 lines). > Hunk #12 succeeded at 3424 (offset 29 lines). > 3 out of 12 hunks FAILED -- saving rejects to file > src/backend/executor/execMain.c.rej > patching file src/backend/executor/execReplication.c > patching file src/backend/executor/nodeModifyTable.c > > -- > Regards, > Dilip Kumar > EnterpriseDB: http://www.enterprisedb.com -- Thanks, -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
