On 31 August 2017 at 14:15, Amit Khandekar <amitdkhan...@gmail.com> wrote: > Thanks Dilip. I am working on rebasing the patch. Particularly, the > partition walker in my patch depended on the fact that all the tables > get opened (and then closed) while creating the tuple routing info. > But in HEAD, now only the partitioned tables get opened. So need some > changes in my patch. > > The partition walker related changes are going to be inapplicable once > the other thread [1] commits the changes for expansion of inheritence > in bound-order, but till then I would have to rebase the partition > walker changes over HEAD. > > [1] > https://www.postgresql.org/message-id/0118a1f2-84bb-19a7-b906-dec040a206f2%40lab.ntt.co.jp >
After recent commit 30833ba154, now the partitions are expanded in depth-first order. It didn't seem worthwhile rebasing my partition walker changes onto the latest code. So in the attached patch, I have removed all the partition walker changes. But RelationGetPartitionDispatchInfo() traverses in breadth-first order, which is different than the update result rels order (because inheritance expansion order is depth-first). So, in order to make the tuple-routing-related leaf partitions in the same order as that of the update result rels, we would have to make changes in RelationGetPartitionDispatchInfo(), which I am not sure whether it is going to be done as part of the thread "expanding inheritance in partition bound order" [1]. For now, in the attached patch, I have reverted back to the hash table method to find the leaf partitions in the update result rels. [1] https://www.postgresql.org/message-id/CAJ3gD9eyudCNU6V-veMme%2BeyzfX_ey%2BgEzULMzOw26c3f9rzdg%40mail.gmail.com Thanks -Amit Khandekar -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
