On Mon, Nov 6, 2017 at 3:31 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/11/06 14:32, David Rowley wrote: >> On 6 November 2017 at 17:30, Amit Langote wrote: >>> On 2017/11/03 13:32, David Rowley wrote: >>>> On 31 October 2017 at 21:43, Amit Langote wrote: [....] > > Attached updated set of patches, including the fix to make the new pruning > code handle Boolean partitioning. >
I am getting following warning on mac os x: partition.c:1800:24: warning: comparison of constant -1 with expression of type 'NullTestType' (aka 'enum NullTestType') is always false [-Wtautological-constant-out-of-range-compare] if (keynullness[i] == -1) ~~~~~~~~~~~~~~ ^ ~~ partition.c:1932:25: warning: comparison of constant -1 with expression of type 'NullTestType' (aka 'enum NullTestType') is always false [-Wtautological-constant-out-of-range-compare] if (keynullness[i] == -1) ~~~~~~~~~~~~~~ ^ ~~ 2 warnings generated. Comment for 0004 patch: 270 + /* -1 represents an invalid value of NullTestType. */ 271 + memset(keynullness, -1, PARTITION_MAX_KEYS * sizeof(NullTestType)); I think we should not use memset to set a value other than 0 or true/false. This will work for -1 on the system where values are stored in the 2's complement but I am afraid of other architecture. Regards, Amul -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers