Tom Lane wrote:
"Joshua D. Drake" <[EMAIL PROTECTED]> writes:
It would also be useful to have possible dependencies. I recently saw
a patch come across from Sun, that Tom commented on, something about increase the size of some value to 64bit. I don't recall exactly.
Tom's comments although valid (as usual :)) were that the person missed
a bunch of stuff having to do with the planner.
Some of us may think... well of course that is obvious...
Well either the Sun guy was just lazy, or it isn't obvious. I prefer to think it is not obvious.

IIRC the problem with that patch was basically that the guy had failed
to search all of the source code for references to the struct he wanted
to modify.  This isn't really the fault of the TODO list.  It could be
(probably already is) a hint in the developer's FAQ ... but I can't see
putting that sort of generic how-to-develop-a-good-patch kind of info
into every TODO item.

I entirely assumed that your references were correct. It was just the only example that I could think up off the top of my head.

I was more trying to display a good use of possible dependecies.


Joshua D. Drake

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
       choose an index scan if your joining column's datatypes do not


   === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
   Providing the most comprehensive  PostgreSQL solutions since 1997

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to