Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Bruce Momjian wrote:
>> Without a reply from Peter, I have to assume the patch is valid.

> To make it more explicit: I think the patch is stupid, but if someone 
> wants to review it, go ahead.  But I am not comfortable with the "if no 
> one objects, I'll just commit it" mode that is sometimes going on.  Has 
> anyone actually tested the patch?

Perhaps more to the point: a refactorization patch is all about beauty
in the eye of the beholder.  If Peter, the original author of the guc
code, thinks that it's a disimprovement, I think it's a hard argument
to make that the patch should go in anyway.

                        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Reply via email to