Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Surely the measurement unit should be kbytes or disk blocks. And why > >> aren't you using that GUC UNITS infrastructure Peter put in? > > > Agreed. I have applied the following patch to make it kilobytes, and > > documented it. I didn't put '-1kB' in the postgresql.conf file because > > the -1 value is special. (ideas?) > > Hmm, that could be a little bit ugly. Suggestion: redefine the value > such that files *greater than* the given size are logged, and then zero > can be the "off" position, and we need not worry about whether -1 is > -1 byte or -1 kbyte.
Uh, the problem is that if you want all files logged, 1 does everything 1kb and larger, skipping a 500-byte file, for example. There are also many places where -1 is off and 0 is all, so we would be inconsistent with that too. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend