Brian Moore <[EMAIL PROTECTED]> writes:
> please find attached my support for printing/exporting
> xml from postgresql.

A few quick comments:

- why is it necessary to include an entire hash table implementation?
  Why does this code require a hash table to begin with, considering
  the relatively small size of pg_type? ISTM something far simpler
  (for example, a dynamically allocated sorted array and a binary
  search) would be sufficient.

- testing code doesn't belong in libpq

- you'll need to update the libpq docs

- you should follow the libpq API naming convention: the function
  should be look like some variant of PQresultAsXML()

- context diffs are the preferred format


---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?


Reply via email to