I have changed the name of the new parse function to xml_valid and fixed a reference to SortMem which meant that the code as supplied would work against 7.3 and 7.4 but wouldn't work in CVS. Oops! Patch is attached.
Patch applied.
A few comments on the module:
- can you include some licensing information? "Distributed under the same terms as PostgreSQL, Copyright ..." should be sufficient unless you'd prefer another license
- some information on how to configure the location of the libxml2 headers / libs would be good, I think
- the readme for both 'contrib/xml' and 'contrib/xml2' is called 'README.pgxml', yet neither module is actually named 'pgxml'
-Neil
---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings
