Andrew Dunstan wrote: > Bruce Momjian wrote: > > >+ if (toupper(*src) != toupper(*src)) > > > > > > Shouldn't this be > > if (toupper(*src) != toupper(*dst)) > > ? >
Yep, fixed. > For completeness, you should probably also check for network > drive paths ("\\machine\sharename\foo"). Oh, OK. > > I also think we should just canonicalise everything early, and > then never have to worry about / vs \ again. > > I must confess I think this scheme is overkill - I can't think > of a use case where one would want a relocatable installation > which would any pattern other than the one we are thinking of > for the windows binary installer. Are we taking flexibility too > far? This code might be used on Unix too. -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 7: don't forget to increase your free space map settings