Only two things to add: you forgot to add `cachedump.o' to the list of OBJS in the utils/adt Makefile.

Mark Kirkwood wrote:
+typedef struct
+{
+       uint32          bufferid;
+       Oid                     relfilenode;
+       Oid                     reltablespace;
+       Oid                     reldatabase;
+       bool            isdirty;
+       uint32          refcount;
+       BlockNumber     blocknum;
+
+} CacheDumpRec;

You should probably make `isdirty' the last member of this struct, so as to reduce alignment/padding requirements (this won't actually save any space right now, but it might save some space if more members are added to the struct in the future).


-Neil

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Reply via email to