Uh, couldn't the delimiter be a backslash in CVS mode? + #define BADCHARS "\r\n\\"
Also, should we disable DELIMITER and NULL from sharing characters? --------------------------------------------------------------------------- David Fetter wrote: > On Sun, Jan 29, 2006 at 10:20:47PM -0500, Neil Conway wrote: > > On Sun, 2006-01-29 at 17:03 -0800, David Fetter wrote: > > > Another followup, this time with the comment done right. > > > > + /* Disallow the forbidden_delimiter strings */ > > + if (strcspn(cstate->delim, BADCHARS) != 1) > > + elog(ERROR, "COPY delimiter cannot be %#02x", > > + *cstate->delim); > > + > > > > The comment is still wrong: referencing "forbidden_delimiter" makes > > it sound like there is something named forbidden_delimiter, but > > there is not (at least in the patch as submitted). > > > > The patch should also use ereport rather than elog, because this > > error message might reasonably be encountered by the user. > > Patch with BADCHARS attached :) > > Cheers, > D > -- > David Fetter [EMAIL PROTECTED] http://fetter.org/ > phone: +1 415 235 3778 > > Remember to vote! [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: Have you checked our extensive FAQ? > > http://www.postgresql.org/docs/faq -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org