On Tue, Jan 31, 2006 at 09:50:26PM -0600, Andrew Dunstan wrote: > David Fetter said: > > On Tue, Jan 31, 2006 at 08:03:41PM -0500, Bruce Momjian wrote: > >> Uh, couldn't the delimiter be a backslash in CVS mode? > > > > I don't think so. Folks? > > Using backslash as a delimiter in CSV would be odd, to say the least. As an > escape char it is occasionally used, but not as a delimiter in my > experience. Maybe we should apply the "be liberal in what you accept" rule, > but I think this would be stretching it.
<aol>So do I.</aol> > >> Also, should we disable DELIMITER and NULL from sharing characters? > > > > That's on about line 916, post-patch: > > > > /* Don't allow the delimiter to appear in the null string. */ > > if (strchr(cstate->null_print, cstate->delim) != NULL) > > ereport(ERROR, > > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > errmsg("COPY delimiter must not appear in the NULL > > specification"))); > > > > I suppose that a different error code might be The Right Thingâ¢ > > here. > > ERRCODE_WHAT WERE_YOU_THINKING ? That's an excellent candidate, or maybe ERRCODE_INVALID_PARAMETER_VALUE. My vote is for ERRCODE_D00D_WTF ;) Maybe we need an error code for mutually incompatible param values. Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match