Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
            if (pset.c->db->asyncStatus != PGASYNC_BUSY)
            {
                break;
            }

There already is a defined API for this, namely PQisBusy().

In any case, I rather concur with the XXX comment: busy-waiting like
this sucks.  The correct way to do this is to get the socket numbers for
the connections (via PQsocket), wait for any of them to be read-ready
according to select() (or for the timeout to elapse, assuming that we
think that behavior is good), then cycle through PQconsumeInput() and
PQisBusy() on each connection.  See
http://www.postgresql.org/docs/8.2/static/libpq-async.html

                        

In that case I guess Greg has some work to do :-) . Looks like there are about five such calls in toto, so it's not a huge tragedy.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to