"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I've had a chance to look at this now, and although it certainly does > seem workable, there's a lot of duplication of code that I feel uneasy > about. describeOneTableDetails essentially already duplicates the > table buildling code in printQuery, so I would be creating a third > copy of the same logic.
> This makes me wonder whether print.c could offer something a bit more > helpful to callers wishing to DIY a table; we could have a > table-building struct with methods like addHeader and addCell. > What do you think? Overkill, or worthy pursuit? Once you have two occurrences of a pattern, it's reasonable to assume there will be more later. +1 for building a little bit of infrastructure. regards, tom lane - Sent via pgsql-patches mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches