Pavan Deolasee napsal(a):
On Fri, Jun 13, 2008 at 9:38 PM, Zdenek Kotala <[EMAIL PROTECTED]> wrote:
I attached code cleanup which is related to in-place upgrade. I replace
direct access to PageHeader structure with already existing macros and I
removed also unnecessary retyping.

A quick review comment:

Thanks you for your review,

One thing I noticed is that the modified definition of HashMaxItemSize
now does not account for the size of ItemId which may not be the right
thing. Please recheck that.

Good catch. I lost in basic arithmetic. What I see now that original definition count sizeof(ItemIdData) twice and on other side it does not take care about MAXALING correctly. I think correct formula is:

#define HashMaxItemSize(page) \
        (PageGetPageSize(page) - \
          ( MAXALIGN(SizeOfPageHeaderData + sizeof(ItemIdData))+ \
            MAXALIGN(sizeof(HashPageOpaqueData)) \

What do you think?

        Thanks for your comments Zdenek

Zdenek Kotala              Sun Microsystems
Prague, Czech Republic

Sent via pgsql-patches mailing list (
To make changes to your subscription:

Reply via email to