Pavan, Heikki,

Is it OK now or do you have any comments?

        Thanks Zdenek

Zdenek Kotala napsal(a):
Pavan Deolasee napsal(a):
On Fri, Jul 4, 2008 at 4:25 PM, Heikki Linnakangas

No, there's a itemsz = MAXALIGN(itemsz) call before the check against

Ah, right. Still should we just not MAXALIGN_DOWN the Max size to
reflect the practical limit on the itemsz ? It's more academical
though, so not a big deal.

Finally I use following formula:

#define HashMaxItemSize(page) \
     MAXALIGN_DOWN(PageGetPageSize(page) - \
       ( SizeOfPageHeaderData + sizeof(ItemIdData) ) - \
        MAXALIGN(sizeof(HashPageOpaqueData)) )

I did not replace PageGetPageSize(page), because other *MaxItemSize has same interface.

Revised patch is attached.



Sent via pgsql-patches mailing list (
To make changes to your subscription:

Reply via email to