Ben I still think that it would have been good to discuss the valueHolder changes in Spec before doing it. Because it broke the tools of people that used Spec like martin and clement as well as the documentation ignaccio wrote. We should be cautious about other people too.
Stef > On 27 Jan 2014, at 20:08, Sven Van Caekenberghe <s...@stfx.eu> wrote: >> Are the compatible ? >> Does one have to come before the other ? >> Are they both needed ? > > I think we should drop >> https://pharo.fogbugz.com/f/cases/12717/ReactiveVariable-NewValueHolder > > and integrate >> https://pharo.fogbugz.com/f/cases/12684/NewValueHolder-Enhancements > > For at least two reasons: > - I added hooks for Spec to continue working with the slice I proposed > (otherwise no more Spec fix until the release) > - I do not have to review it :P > > Ok maybe the second point is not that relevant LOL > Just that I am sure that the fix I proposed works well with Spec. > And I an pretty sure the other will break it :) > > I was not aware of another case related to this. > It is not flagged Spec nor my name, so there is no way for me to guess it > exists. > > Ben
