Hi Norbert, Great. Please play with the extension and let us know how it goes.
Cheers, Doru On Fri, Dec 26, 2014 at 3:31 PM, Norbert Hartl <[email protected]> wrote: > Doru, > > Am 26.12.2014 um 14:38 schrieb Tudor Girba <[email protected]>: > > Hi Norbert, > > My reply is inlined. > > dito > > On Wed, Dec 24, 2014 at 5:15 PM, Norbert Hartl <[email protected]> wrote: > >> >> Am 23.12.2014 um 22:46 schrieb Tudor Girba <[email protected]>: >> >> The Raw view is a tree :) >> >> It looks like shallow tree :) Maybe I miss the point but my appearance to >> this is something like that. Let's have a class >> >> Object subclass: #TTT >> instanceVariableNames: 'col' >> classVariableNames: '' >> category: 'ZZZ' >> >> and >> >> TTT>>#initialize >> col := OrderedCollection new addAll: (1 to: 10); yourself >> >> If I inspect "TTT new" I get >> >> >> With the intention to examine the elements of the collection I unfold (1) >> the col >> >> >> So instead of the elements I get the internal representation of >> OrderedCollection. Clicking array (2) >> >> >> I get a new column with the representation of array (same as on the left >> side). And here Clement is right because it would be helpful to see the >> elements in the right column. By clicking the "10 items" tab (3) and then >> an element (4) I can see the content of that. >> So what I wanted to say is that I found it a lot of clicks necessary to >> get the information I want. I see it is a raw view and from that POV >> everything seems right. >> > > The tree interface works only for a few elements in a collection, but it > will fail for most real collections because it does not scale (you will > have a hard time finding anything). > > Nevertheless, here is a simplistic solution (it will have to be extended a > bit). Adding this method: > > Collection>>gtInspectorVariableValuePairs > | pairs | > pairs := super gtInspectorVariableValuePairs. > self doWithIndex: [ :each :index | > index > 42 ifTrue: [ ^ pairs ]. > pairs add: (index asTwoCharacterString -> each) ]. > ^ pairs > > <collection-items-in-raw.png> > > In my opinion this makes the Raw view less "Raw". > > Sure. I didn't mean to change the raw view because taken its name it is > perfectly doing what it promises. It's just that in most of the cases I'm > not really interested in a raw view but customized views that help > examine/navigating (which is the point of having gt inspector in the first > place, right?). > Thanks for the code snippet. I'll take that as an entry point to play with > it. Would have taken me some time to get that. > > > Coming from the old tools it is not a point of getting used to it or not. >> This raw view is not an improvement over the old it is a completely >> different view. >> > As Ben sad it might good to think about providing a view compatible with >> the old explorer view (fast drill down). Having that view be a default >> could be left to the user as it could be a setting. >> > Does that makes sense? >> > > Your comparison is correct: the current Raw view does provide less than > the old one. However, the raw view used to be the inspector, but now it is > but one of the views in the inspector and it was not meant to replace or > improve the old one. The inspector as a whole does want to improve on the > old one, and I think this is where we should focus our comparisons on :). > Nevertheless, let me know what you think about the extension proposed above. > > But, here is the other thing that the new inspector allows for. In the TTT > class you can now add something like: > > TTT>>gtInspectorItemsIn: composite > <gtInspectorPresentationOrder: 0> > composite list > title: 'Col'; > display: [ col ] > > This is about as cheap as a printOn: and you get: > > <inspector-custom-col.png> > > That's really good. I'm sure I gonna love it soon. > > You might say that you do not want to stop your inspection to do this, but > actually you should not stop. You can write this method directly in the > Meta tab and the inspector updates live and you can continue from where you > left off with a tiny detour. > > Norbert >> >> P.S.: Are the miller columns configurable. I want to play with amount of >> columns. Until now I preferred three columns if space is available. Any >> pointers to that would be great. >> > > There are two things: > 1. There is a setting to set the default amount of panes. > 2. The columns are adjustable dynamically by resizing the scrollbar at the > bottom. > > > Ok, I'll try all of that and then I return to 4.0. Thanks for the help! > > Norbert > > -- www.tudorgirba.com "Every thing has its own flow"
