On 05 Sep 2015, at 13:29, Yuriy Tymchuk <[email protected]> wrote:
You can see changes for that patch here:
https://github.com/pharo-project/pharo-core/commit/2536752ecdd88e15b00c6d3e29cb055d108731c8
YES, we have that for years now.
and how many people read one change?
True, it is one click away, but the view is quite nice (not something that can
be reproduced in an email).
No it is not because I delete the mail with these headers and I cannot
find a list on the web to find
the diff.
On 05 Sep 2015, at 13:23, stepharo <[email protected]> wrote:
On 05 Sep 2015, at 11:40, stepharo <[email protected]> wrote:
How can I see the changes?
Our process is not good. Most of us do not get any chance understanding what is
changing.
-> download the image before it was added
-> merge the slice.
Yes, our process is not good… but from a review perspective, this issue is the
best we can do.
*two* reviews, both from people actively contributing to exactly that part of
the system.
If we require more, we will be back at a process where due to Fear we do
nothing.
I do not want to require more. I want to see all the changes that we are doing
without having to download an image
and doing merge.
I read many squeak changes like that and IT WORKS.
Stef
Hi,
This is a side effect of
https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcements-for-a-single-action
(which was reviewed by two people, so not obvious).
What happened is that #updatePackageGroupAndClassList calls itself via
#selectedClass: leading to a loop.
Should be easy to fix for the people involved in case 16475.
Marcus
On Sat, Sep 5, 2015 at 8:51 AM, stepharo <[email protected]> wrote:
Hi
I do not know if this is linked to recent changes but we cannot remove classes
or move them to another package.
Stef
--
--
Marcus Denker -- [email protected]
http://www.marcusdenker.de
