> On 06 Sep 2015, at 01:41, Peter Uhnák <[email protected]> wrote:
> 
> git clone https://github.com/pharo-project/pharo-core.git
> cd pharo-core/
> git show 2536752ecdd88e15b00c6d3e29cb055d108731c8
> 
> But this is post-integration, we want to review things before they break 
> something, not after.
> So ideally monkey reviews code on CI and if it passes the diff is sent from 
> CI to the mailing list.
> 
> Also these commits combine several unrelated issues, which is not good for 
> review.
> 
> Isn't what Squeak uses open-source and available somewhere? Can't we just 
> reuse it?
> 
> Peter

You are right, Peter. But the way the rest of the world (and many people using 
git from Pharo or other Smalltalk implementations) is that you propose patches 
which I believe are quite similar to commits. That would be the equivalent of 
our slice, I guess.

Sven

Reply via email to