Hi nicolai here is what I do. I always download the latest image via a bash script because updating can fail since loading package without a baseline may break.
After I use the set up described by guille blog post and I reuse my downloaded clone (to avoid to trash my SSD). Esteban told me that he will do a video: - for producing a PR - for reviewing Stef On Thu, Aug 31, 2017 at 12:06 AM, Nicolai Hess <[email protected]> wrote: > Hi, > > I am now able to use iceberg on windows, thanks for the help. > > But I am still a bit unsure about how the review and contribution workflow > should work. > > up to pharo 6 I just load a latest image, > - load the slice from a fogbugz number and was able to review the change > - or create a slice and upload it to the inbox > > in pharo 7 > - what is the equivalent to "getting the latest image" (and being able to > load and review a fix), > up to pharo 6 I just > - load the latest image in pharolauncher (or from the command line). > - opened the inbox repository. > - load and review change/fix > - throw away this change (close image without save) > - reopen that image to move on with the next item to review. > > But now, do I have to update my local branch for every new pull > request ? And how do I do this ? In other git project I would, I would > fetch upstream, checkout master, merge with upstream/master, push the > master to my fork origin > How should this be done with my pharo 7 fork ? (And do we only work on > the development brach instead of the master)? > > And do I this only in the command line or do I manage my fork (and keep > it up to date) from within pharo with iceberg ? > How do I actually access the pull requests from within pharo ? Maybe I > am stupid, but I just can not find it. > I would like do this steps, (as I was used to it from the prior > contribution process, by loading code from the inbox) > - Just look at the changes > - apply the changes > - throw away this changes, and move one with the next fix review > > And the same for creating a fix / pull request. Do I need to be up to date > with my own fork, or only the local copy of the pharo repository ? > Again, for pharo 6 I would just load a latest image, make my changes / > code fixes and create a slice. Save to the inbox -> done. > And looking at iceberg, I have really no clue how to upload a fix. > > I see that other people are using the new process, and I feel a bit lost > and closed out of the pharo 7 development process, as I am at the moment > unable to understand how this work. > Are there any other resources I missed ? > > > > > 2017-08-11 19:30 GMT+02:00 Stephane Ducasse <[email protected]>: > >> Nicolai >> >> I started super simple. I clone and point my fresh dled image to the use >> the clone. >> Then I can do simple PR and review the issues. >> I will do the installation several times to learn (but not clone). >> >> I'm not sure that it is needed but I have >> cd /Users/ducasse/Library/Preferences/pharo/7.0 >> >> StartupPreferencesLoader default executeAtomicItems: { >> StartupAction >> name: 'Git Settings' >> code: [ >> FileStream stdout >> cr; nextPutAll: 'Setting the ssh >> credentials'; cr. >> Iceberg enableMetacelloIntegration: true. >> IceCredentialsProvider useCustomSsh: true. >> IceCredentialsProvider sshCredentials >> username: 'git'; >> publicKey: >> '/Users/ducasse/.ssh/id_rsa.pub'; >> privateKey: >> '/Users/ducasse/.ssh/id_rsa'. >> IceCredentialsProvider >> plaintextCredentials: >> (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; >> yourself ). >> FileStream stdout >> cr; nextPutAll: 'Finished'; cr ]. >> }. >> >> >> >> On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito < >> [email protected]> wrote: >> >>> I extended the document with some windows specific instructions also. >>> >>> On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <[email protected]> >>>> wrote: >>>> >>>>> >>>>> >>>>> 2017-08-10 17:17 GMT+02:00 Guillermo Polito <[email protected] >>>>> >: >>>>> >>>>>> Hi, >>>>>> >>>>>> I've made some write up for the pharo part (not metacello or external >>>>>> projects) >>>>>> >>>>>> https://github.com/guillep/PharoIntegrationProcess/wiki/Cont >>>>>> ribute-a-fix-to-Pharo >>>>>> >>>>>> Of course, expect bugs on it :) Not everything is smooth. If you have >>>>>> comments, they are welcome. >>>>>> >>>>> >>>>> >>>>> >>>>> [image: Inline-Bild 1] >>>>> >>>>> >>>>> In option 2, I think this should be "Click on the Edit button", >>>>> >>>> >>>> Thanks, fixed! >>>> >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> Guille >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>>> >>>>>> Guille Polito >>>>>> >>>>>> >>>>>> Research Engineer >>>>>> >>>>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>>>> <http://www.cnrs.fr> >>>>>> >>>>>> >>>>>> >>>>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>>>> >>>>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> >>>> >>>> Guille Polito >>>> >>>> >>>> Research Engineer >>>> >>>> French National Center for Scientific Research - *http://www.cnrs.fr* >>>> <http://www.cnrs.fr> >>>> >>>> >>>> >>>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>>> >>>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>>> >>> >>> >>> >>> -- >>> >>> >>> >>> Guille Polito >>> >>> >>> Research Engineer >>> >>> French National Center for Scientific Research - *http://www.cnrs.fr* >>> <http://www.cnrs.fr> >>> >>> >>> >>> *Web:* *http://guillep.github.io* <http://guillep.github.io> >>> >>> *Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013> >>> >> >> >
