Hi, On Saturday 23 August 2008 18:50:37 Pierre Joye wrote: > > -__inline int > > +static inline int > > __inline is known on gcc and windows, adding a define for solaris > sounds more appropriate.
The commit adds AC_C_INLINE in config.m4, which defines "inline" appropriatly to __inline or __inline__ if the compiler does not know the "inline" keyword. Basically it does what you added in your commit, but without forcing inlining, and unlike a test against some known compiler macros, this will work on all compilers by checking what they actually support. For instance your code will check only GCC and the MS compiler, and the last #else may miss the fact that the compiler actually supported __inline or __inline__. For "static" before "inline", it avoids a problem with the Sun compiler (without static the compiler references the function but does not actually outputs it). > > > +#include "php_config.h" > > that breaks on win. Sorry > > > #if PHP_WIN32 > > # include "win32/php_stdint.h" > > #elif HAVE_STDINT_H > > # include <stdint.h> > > #endif > > +#if !PHP_WIN32 > > little #else instead? :) > > > +# ifndef HAVE_U_INT32_T > > + typedef uint32_t u_int32_t; > > +# endif > > +#endif > > I don't understand this part. If HAVE_U_INT32_T is not defined, you > still use u_int32_t? If HAVE_U_INT32_T is not defined that means that u_int32_t is not defined. So I define u_int32_t it to uint32_t. This makes sense for me. > > I will commit the fixes for windows soonish but the last problem seems > to be wrong (sorry but I don't have any solaris to test). > > Cheers, > -- > Pierre > > http://blog.thepimp.net | http://www.libgd.org > Regards, Arnaud -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
