Don't do this please. Why did you feel the need to go back and change my patch including the NEWS entry? I knew what I was doing when I set the default behavior to SORT_REGULAR and this was discussed with both 5.3 and 5.2 RMs. With your change it'l back to the stupid old behavior of:

$array = array(new stdClass(), new stdClass(), new Foo());
$array = array_unique($array);

And now $array has only 1 element. I really hate having tell PHP not to be stupid, rather than having it default to being smart.

I'm going to revert this.

-Andrei

Moriyoshi Koizumi wrote:
moriyoshi               Thu Feb 12 18:29:15 2009 UTC

Modified files: /php-src/ext/standard array.c Log:
  * Fix bug #47370 (BC breakage of array_unique())
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.471&r2=1.472&diff_format=u
Index: php-src/ext/standard/array.c
diff -u php-src/ext/standard/array.c:1.471 php-src/ext/standard/array.c:1.472
--- php-src/ext/standard/array.c:1.471  Mon Feb  9 10:47:19 2009
+++ php-src/ext/standard/array.c        Thu Feb 12 18:29:15 2009
@@ -21,7 +21,7 @@
    +----------------------------------------------------------------------+
 */
-/* $Id: array.c,v 1.471 2009/02/09 10:47:19 dmitry Exp $ */
+/* $Id: array.c,v 1.472 2009/02/12 18:29:15 moriyoshi Exp $ */
#include "php.h"
 #include "php_ini.h"
@@ -2924,7 +2924,7 @@
        };
        struct bucketindex *arTmp, *cmpdata, *lastkept;
        unsigned int i;
-       long sort_type = PHP_SORT_REGULAR;
+       long sort_type = PHP_SORT_STRING;
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a|l", &array, &sort_type) == FAILURE) {
                return;




--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to